Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More shelleyBasedEraConstraint constraints #149

Merged
merged 1 commit into from
Jul 31, 2023
Merged

More shelleyBasedEraConstraint constraints #149

merged 1 commit into from
Jul 31, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 27, 2023 •
edited
Loading

Changelog

- description: |
    More shelleyBasedEraConstraint constraints
  compatibility: compatible
  type: feature

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/more-shelleyBasedEraConstraint-instances branch from e1af137 to 3d1a360 Compare July 27, 2023 23:55
@newhoggy newhoggy changed the title More shelleyBasedEraConstraint instances More shelleyBasedEraConstraint constraints Jul 27, 2023
@newhoggy newhoggy marked this pull request as ready for review July 28, 2023 00:17
@newhoggy newhoggy force-pushed the newhoggy/more-shelleyBasedEraConstraint-instances branch from 3d1a360 to f9d5995 Compare July 28, 2023 00:18
carbolymer
carbolymer reviewed Jul 28, 2023
View reviewed changes
cardano-api/internal/Cardano/Api/Orphans.hs
{-# LANGUAGE StandaloneDeriving #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE UndecidableInstances #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid this extension? Why it's needed?

Copy link
Collaborator Author

@newhoggy newhoggy Jul 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why we need it:


internal/Cardano/Api/Orphans.hs:97:10: error:
    • Illegal nested constraint ‘ToJSON (HeaderHash blk)’
      (Use UndecidableInstances to permit this)
    • In the instance declaration for ‘ToJSON (Tip blk)’
   |
97 | instance ToJSON (HeaderHash blk) => ToJSON (Tip blk) where
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Note, the offending instance already exists in cardano-cli. This PR merely moves it here.

See https://github.com/input-output-hk/cardano-cli/blob/newhoggy/use-AnyShelleyToBabbageEra-from-cardano-api-instead/cardano-cli/src/Cardano/CLI/Orphans.hs#L48

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your link returns 404 error for me.

carbolymer
carbolymer previously requested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/input-output-hk/cardano-api/pull/149/files#r1277303412

@newhoggy newhoggy requested a review from carbolymer July 28, 2023 16:13
@newhoggy newhoggy force-pushed the newhoggy/more-shelleyBasedEraConstraint-instances branch from f9d5995 to e667af3 Compare July 29, 2023 04:41
@newhoggy newhoggy added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit 9a2c918 Jul 31, 2023
17 checks passed
@newhoggy newhoggy deleted the newhoggy/more-shelleyBasedEraConstraint-instances branch July 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhoggy @carbolymer